Bug in the Physical DMG calculation

"

Flexn wrote:

2. 73 * (1 + 0.51 + 0.636 + 0.12) + (8 + 3) * (1 + 0.51 + 0.12) = 183.35 (183 Rounded), which is not what the ingame DPS display reads.

This calculation is incorrect in that you have to round the physical increase you get from strength. It's either 0.63 or 0.64 (depending on whether you round naturally or down) but it's NOT 0.636. This is due to the fact that all attributes are rounded values and physical increase from strength is considered an attribute. You can look that up somewhere on the forums.

"

Flexn wrote:

3. I do NOT believe that +physical damage on gear other than weapons is not affected by weapon damage increases, because of the above calculation and because +elemental damage on gear other than weapons IS affected by weapon damage increases, e.g. the "increased weapon elemental damage" mod.

I didn't believe it either at first. But trust me, I've been there, that whole thing gave me a huge headache when I created my DPS spreadsheet. The whole reason why elemental damage on gear is so overpowered is because all elemental damage (from weapons and gear) is put into a single pool (by type) and then increased by all modifiers. But for physical damage this does not occur. You have to track physical damage sources from weapons separately from sources on gear.

You can prove that yourself by simplifying the example. Strip your character of all gear, put on a simple starter weapon and observe how the damage values change when putting on an Iron Ring. The range in which you see differences depends a bit on the increases and the weapon you have but you will see what I mean.

I can't post any specific examples since I'm at work right now.

"

Flexn wrote:

Edit: 4. Even if you were right, it still would not work with epeli's example. He is banned for whatever reason yet I believe that his example is correct.

I didn't check that example out yet but from my experience "+157% increased phys dmg from other sources" isn't specific enough in this case because of those differences. It might well be that not all of those 157% can be applied to physical damage from gear.

This is very interesting, thanks for bringing some light in this matter. I will adjust my dps calc to test it out as soon as I will be back home.
I'm still curious if that is intended to work that way.