Bug in the Physical DMG calculation

It's going mathematically now:

The following example is only with minimum physical dmg, but the bug also exists with maximum physical dmg

Base Physical Damage:

My Weapon does 73 Physical Damage
I have a Ring with 8 Physical Damage
I have a Quiver with 3 Physical Damage

Multiplicators:

My Attack Skill has 51% Increased Physical Damage
I use Iron Grip with 318 Strength ( = 63% Increased Physical Damage)
I have 12% Increased Physical Damage from Cruel Oak Quest Reward

Now the calculation would be:

(73 + 8 + 3)*(1 + 0.51 + 0.63 + 0.12) = 189.84 Physical Damage (190 Rounded)

But ingame it shows 184 Physical Damage

I tried to find out where are the missing 6 Physical Damage and I found the bug:

This is what PoE calculates:

73 * (1 + 0.51 + 0.63 + 0.12) + (8 + 3) * (1 + 0.63 + 0.12) = 184.23 Physical Damage (184 Rounded)

In other words: The Increased Physical Damage from my Skill (Burning Arrow) does not apply to Physical Damage on gear

As you can see in the following picture, this also affects converted damage

Interesting, I think there might be more than that...

Are you sure Cruel Oak's "+12% to Physical Damage" is supposed to be Increased (additive) rather than More (multiplicative)?

"

epeli wrote:

Interesting, I think there might be more than that...

Are you sure Cruel Oak's "+12% to Physical Damage" is supposed to be Increased (additive) rather than More (multiplicative)?

It's certainly "increased" because "more" would be very overpowered and unbalanced, considering that the other rewards are 4% "increased" attack speed and 4% "increased" cast speed

Edit: oh yea, the reward is in cruel, fixed that in the original post

Interesting. Just tested this on a random throwaway ranger. Looks like Oak's bonus is Increased, although Increased is not mentioned anywhere and "+12% to Physical Damage" would be more correct if it was More damage.

115 phys dmg on weapon
12 phys dmg on gear
+33% increased phys dmg from skill (ice shot)
+12% from Cruel Oak
+157% increased phys dmg from other sources
no sources of more phys dmg

Autoattack phys dmg: 327 (expected: 342)
Ice shot phys dmg: 221 (expected: 230)

And without +flat phys dmg gear:

Autoattack: 309 (296 expected)
Ice shot: 208 (200 expected)


I don't even know what to say.

"

epeli wrote:

And without +flat phys dmg gear:

Autoattack: 309 (296 expected)
Ice shot: 208 (200 expected)


I don't even know what to say.

You misscalculated something there, my calculator says its 208.38 for ice shot and 309.35 for autoattack, so without flat +phys damage on gear everything works fine.


However

"

115 phys dmg on weapon
12 phys dmg on gear
+33% increased phys dmg from skill (ice shot)
+12% from Cruel Oak
+157% increased phys dmg from other sources
no sources of more phys dmg

Autoattack phys dmg: 327 (expected: 342)
Ice shot phys dmg: 221 (expected: 230)

If my theory was right, it would show 228 for Ice Shot, so the bug is somewhere else, but there certainly is a bug somewhere

Edit: Let's try to calculate it backwards

The Damage without flat +phys on gear is 208.38 so
221 - 208.38 = 12.62
12.62 / 6 * 10 = 21.033
21.033 / 12 = 1.752

So if PoE's calculation with the physical damage on the weapon is correct, the 12 physical damage on gear would have to be multiplied by 1.752; I cant see any combination of 33, 12 and 157 to get anywhere near 75.2. This seems to be alot more complicated than I thought.

"

Flexn wrote:

You misscalculated something there, my calculator says its 208.38 for ice shot and 309.35 for autoattack, so without flat +phys damage on gear everything works fine.

Oops! Yes, sorry about that. Looks like I copypasted the numbers without Oak's bonus - 115*(1+1.57) instead of 115*(1+1.57+0.12).

I checked some other skills as well, looks like all numbers are as expected, as long as there is no flat physical damage on your gear.

bump

There is certainly a bug somewhere

It's indeed not a bug. Your physical damage on gear is in fact increased by your Burning Arrow but it is not increased by strength.

So your physical damage is calculated this way:

73 * (1 + 0.51 + 0.64 + 0.12) + (8 + 3) * (1 + 0.51 + 0.12) = 183.64 Physical Damage

BTW: I believe physical damage from strength is rounded normally and not down, i.e. you have 64% increase not 63.

EDIT: The only increases that are applicable for physical damage from gear are pure (physical) damage increases, i.e. weapon(-specific) damage increases or strength are ignored. So Vipermagi is right in that physical damage on gear is sub-par compared to elemental damage.

"

Wyverex42 wrote:

It's indeed not a bug. Your physical damage on gear is in fact increased by your Burning Arrow but it is not increased by strength.

So your physical damage is calculated this way:

73 * (1 + 0.51 + 0.64 + 0.12) + (8 + 3) * (1 + 0.51 + 0.12) = 183.64 Physical Damage

BTW: I believe physical damage from strength is rounded normally and not down, i.e. you have 64% increase not 63.

EDIT: The only increases that are applicable for physical damage from gear are pure (physical) damage increases, i.e. weapon(-specific) damage increases or strength are ignored. So Vipermagi is right in that physical damage on gear is sub-par compared to elemental damage.

Despite the fact that my calculation for iron grip was indeed wrong, I still believe that you are wrong with your assumptions:

1. According to http://de.pathofexilewiki.com/wiki/Iron_Grip, Iron Grip is 0.2% increased phyical damage per strength point.

2. 73 * (1 + 0.51 + 0.636 + 0.12) + (8 + 3) * (1 + 0.51 + 0.12) = 183.35 (183 Rounded), which is not what the ingame DPS display reads.

3. I do NOT believe that +physical damage on gear other than weapons is not affected by weapon damage increases, because of the above calculation and because +elemental damage on gear other than weapons IS affected by weapon damage increases, e.g. the "increased weapon elemental damage" mod.

Edit: 4. Even if you were right, it still would not work with epeli's example. He is banned for whatever reason yet I believe that his example is correct.